Add package visibility manifest query for accessing browsers on sdk 30#613
Merged
Conversation
agologan
commented
Oct 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this item was addressed in #558 having integrators manually add the query is not ideal.
This PR adds the query in the library manifest and lets the compile process merge it in the resulting package removing the extra integration step.
Thanks for @chrisbanes for also raising awareness on the topic in #599
To note that checking BROWSABLE is enough, as Custom Tabs is just a subset of those packages : https://developer.android.com/training/basics/intents/package-visibility-use-cases#check-browser-available